Skip to content

[beta] 1.79 promotion #124476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2024
Merged

[beta] 1.79 promotion #124476

merged 3 commits into from
Apr 28, 2024

Conversation

Mark-Simulacrum
Copy link
Member

@rustbot
Copy link
Collaborator

rustbot commented Apr 28, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 28, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mark-Simulacrum
Mark more entries in rustc_data_structures as no_inline for docs
532195d 
This is a workaround for rust-lang#122758, but it's not clear why 1.79 requires a
more extensive amount of no_inline than the previous release. Seems like
there's something relatively subtle happening here.
@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never p=50

@bors
Copy link
Collaborator

bors commented Apr 28, 2024

📌 Commit 532195d has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2024
@bors
Copy link
Collaborator

bors commented Apr 28, 2024

⌛ Testing commit 532195d with merge 6b544f5...

@bors
Copy link
Collaborator

bors commented Apr 28, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 6b544f5 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 28, 2024
@bors bors merged commit 6b544f5 into rust-lang:beta Apr 28, 2024
@rustbot rustbot added this to the 1.79.0 milestone Apr 28, 2024
@Mark-Simulacrum Mark-Simulacrum deleted the beta-next branch April 29, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Mark-Simulacrum @rustbot @rust-log-analyzer @bors